He was a very accomplished musician, singer and dancer and had the sort of entertaining and extrovert character needed for shows like the Palladium and the Generation Game.
I didn't like his politics and, yes, he did appear rather self-important and tetchy towards the end of his stint on Strictly but it should be remembered that he was quite elderly by that time.
I give him credit for his long career and accept that I don't know what he was like in "real life", any more than I know what other celebrities and entertainers are like when they are not performing for the camera.